Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/1101#discussion_r164615997
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/agg/TestHashAggrSpill.java
---
@@ -53,59 +51,54 @@
@Rule
public final BaseDirTestWatcher dirTestWatcher = new
BaseDirTestWatcher();
- /**
- * A template for Hash Aggr spilling tests
- *
- * @throws Exception
- */
- private void testSpill(long maxMem, long numPartitions, long
minBatches, int maxParallel, boolean fallback ,boolean predict,
- String sql, long expectedRows, int cycle, int
fromPart, int toPart) throws Exception {
- LogFixture.LogFixtureBuilder logBuilder = LogFixture.builder()
--- End diff --
I can add this back. In general I don't like leaving unused code in the
codebase though.
---
