Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/1101#discussion_r165161146
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java
---
@@ -255,7 +254,6 @@ private HashAggregator createAggregatorInternal()
throws SchemaChangeException,
groupByOutFieldIds[i] = container.add(vv);
}
- int extraNonNullColumns = 0; // each of SUM, MAX and MIN gets an extra
bigint column
--- End diff --
Thanks for catching this. Then we should fix the underlying problem instead
of passing around additional parameters to work around the issue. I will work
on fixing the codegen for the BatchHolder as part of this PR.
---
