Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/1101#discussion_r165513161
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java
---
@@ -255,7 +254,6 @@ private HashAggregator createAggregatorInternal()
throws SchemaChangeException,
groupByOutFieldIds[i] = container.add(vv);
}
- int extraNonNullColumns = 0; // each of SUM, MAX and MIN gets an extra
bigint column
--- End diff --
Ok. I am going to move all the code into one place though. Previously half
the code was in HashAggBatch and the other half was in HashAggTemplate. I'll
also add a comment that this extra code should be removed after DRILL-5728, and
I will also add a comment to DRILL-5728 to reminder the implementer to remove
this extra code.
---
