My mistake Volodymyr. Found some other JDK 8 issues in JIRA not tracked in DRILL-1491
DRILL-4547 Javadoc fails with Java8 DRILL-6163 Switch Travis To Java 8 The following are tracked in DRILL-1491, but it doesn't look like we're addressing these. Are we? DRILL-4329 13 Unit tests are failing with JDK 8 DRILL-4333 DRILL-4329 tests in Drill2489CallsAfterCloseThrowExceptionsTest fail in Java 8 DRILL-5120 Upgrade JDBC Driver for new Java 8 methods DRILL-5680 BasicPhysicalOpUnitTest can't run in Eclipse with Java 8 *DRILL-4547 is a showstopper*. The release build (-Papache-release) fails with far too many Javadoc errors even with doc lint turned off. DRILL-4333, DRILL-4329, DRILL-5120 are JDBC related which is a project by itself. Note that fixing JDBC related issues and adding the command line option to turn doc lint off will likely break Java 7 builds. Folks who voted to get JDK 8 into this release, what is the consensus on JDBC/Java8 ? Also, any volunteers on helping debug TestDrillbitResilience.cancelAfterAllResultsProduced ? On Wed, Mar 7, 2018 at 3:20 PM, Volodymyr Tkach <[email protected]> wrote: > Addition to my last message: > The link with PR for DRILL-1491 https://github.com/apache/drill/pull/1143 > on which the we can see TestDrillbitResilience. > cancelAfterAllResultsProduced > failure. > > 2018-03-07 11:45 GMT+02:00 Volodymyr Tkach <[email protected]>: > > > *To Parth:* > > The failure can only be seen if run on DRILL-1491 branch, because it uses > > jdk 1.8 in pom.xml > > > > <source>1.8</source> > > <target>1.8</target> > > > > 2018-03-07 6:03 GMT+02:00 Sorabh Hamirwasia <[email protected]>: > > > >> Just sent an email on RCA of DRILL-6216 to discuss next steps. > >> > >> > >> Thanks, > >> Sorabh > >> > >> ________________________________ > >> From: Parth Chandra <[email protected]> > >> Sent: Tuesday, March 6, 2018 6:48:21 PM > >> To: dev > >> Subject: Re: [DISCUSS] 1.13.0 release > >> > >> We have two items remaining - > >> > >> DRILL-1491 - Ideally, I would like to make sure that CANCEL is handled > >> correctly with JDK 8. If the failure of the unit test is because the > >> cancel > >> is received after the query is completed, then the issue is less severe, > >> but I would like to be sure that this is the case. > >> Are there others who see the DrillbitResilience tests failing for them? > >> Can > >> we try to assist Volodymyr? I don't see the failures myself. > >> > >> DRILL-6216 - this is a showstopper. > >> > >> > >> On Wed, Mar 7, 2018 at 5:27 AM, Kunal Khatua <[email protected]> > >> wrote: > >> > >> > Hi Parth > >> > > >> > DRILL-6216 is a release blocker that is being currently looked into. > >> > > >> > Ref: > >> > DRILL-6216: Metadata mismatch when connecting to a Drill 1.12.0 with a > >> > Drill-1.13.0-SNAPSHOT driver > >> > https://urldefense.proofpoint.com/v2/url?u=https-3A__issues. > >> apache.org_jira_browse_DRILL-2D6216&d=DwIBaQ&c=cskdkSMqhcnjZ > >> xdQVpwTXg&r=gRpEl0WzXE3EMrwj0KFbZXGXRyadOthF2jlYxvhTlQg&m=xu > >> Rz02Sbprxvbtw1OrBuDvlRbp2lh9mz3sxpP5-wHPs&s=txeKaKzF67flAi48 > >> DUNLgMWbxje1GXWxfFpG6BEPXk0&e= > >> > > >> > Please add it to the list of required commits as well. > >> > > >> > Thanks > >> > ~ Kunal > >> > On 3/6/2018 9:53:06 AM, Volodymyr Tkach <[email protected]> > wrote: > >> > Right now i haven't found the reason of > >> > TestDrillbitResilience.cancelAfterAllResultsProduced failure, most > >> likely > >> > the cause of the failure is that the query is able to have been > >> completed > >> > before cancellation request is processed. > >> > This test not only the case, there is one more ignored test > >> > TestDrillbitResilience.cancelAfterEverythingIsCompleted and jira > >> > DRILL-3967 > >> > created, although the environment is AWS. > >> > > >> > Maybe it makes sense to ignore this test to unblock the release and > >> merge > >> > JDK8 changes? > >> > > >> > > > > >
