Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1145#discussion_r173043030
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -312,6 +312,11 @@ public synchronized void connect(String connect,
Properties props) throws RpcExc
if (connected) {
return;
}
+
+ if (props == null) {
--- End diff --
Not totally sure what you mean here. Since there are 2 other overloaded
methods which call's this method internally. They do pass null props and are
used across multiple tests.
May be I can check for props in those method instead and create a instance
of it if needed ? Then we can place NotNull tag on this connect method. That
will not require to change any existing tests.
---
