Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1145#discussion_r173234604
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -312,6 +312,11 @@ public synchronized void connect(String connect,
Properties props) throws RpcExc
if (connected) {
return;
}
+
+ if (props == null) {
--- End diff --
My recommendation is to change other 2 overloaded methods to pass `new
Properties()` instead of `null` and making it explicit that `null` is not
allowed (avoid passing `null` and checking for `null` at the same time).
---
