[GitHub] drill pull request #1181: DRILL-6284: Add operator metrics for batch sizing ...

[paul-rogers]

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1181#discussion_r177617387
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
 ---
    @@ -463,4 +488,20 @@ protected boolean setupNewSchema() throws 
SchemaChangeException {
         }
         return exprs;
       }
    +
    +  private void updateStats() {
    +    stats.setLongStat(Metric.NUM_INCOMING_BATCHES, 
flattenMemoryManager.getNumIncomingBatches());
    +    stats.setLongStat(Metric.AVG_INPUT_BATCH_SIZE, 
flattenMemoryManager.getAvgInputBatchSize());
    +    stats.setLongStat(Metric.AVG_INPUT_ROW_WIDTH, 
flattenMemoryManager.getAvgInputRowWidth());
    +    stats.setLongStat(Metric.TOTAL_INPUT_RECORDS, 
flattenMemoryManager.getTotalInputRecords());
    +    stats.setLongStat(Metric.NUM_OUTGOING_BATCHES, 
flattenMemoryManager.getNumOutgoingBatches());
    +    stats.setLongStat(Metric.AVG_OUTPUT_BATCH_SIZE, 
flattenMemoryManager.getAvgOutputBatchSize());
    +    stats.setLongStat(Metric.AVG_OUTPUT_ROW_WIDTH, 
flattenMemoryManager.getAvgOutputRowWidth());
    +    stats.setLongStat(Metric.TOTAL_OUTPUT_RECORDS, 
flattenMemoryManager.getTotalOutputRecords());
    +  }
    +
    +  @Override
    +  public void close() {
    --- End diff --
    
    Is `super.close()` needed?


---