[GitHub] drill pull request #1181: DRILL-6284: Add operator metrics for batch sizing ...

[paul-rogers]

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1181#discussion_r177617922
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatchMemoryManager.java
 ---
    @@ -29,6 +29,50 @@
       private int outgoingRowWidth;
       private RecordBatchSizer sizer;
     
    +  /**
    +   * operator metric stats
    +   */
    +  private long numIncomingBatches;
    +  private long sumInputBatchSizes;
    +  private long sumInputRowWidths;
    +  private long totalInputRecords;
    +  private long numOutgoingBatches;
    +  private long sumOutputBatchSizes;
    +  private long sumOutputRowWidths;
    +  private long totalOutputRecords;
    +
    +  public long getNumIncomingBatches() {
    +    return numIncomingBatches;
    +  }
    +
    +  public long getTotalInputRecords() {
    +    return totalInputRecords;
    +  }
    +
    +  public long getNumOutgoingBatches() {
    +    return numOutgoingBatches;
    +  }
    +
    +  public long getTotalOutputRecords() {
    +    return totalOutputRecords;
    +  }
    +
    +  public long getAvgInputBatchSize() {
    +    return RecordBatchSizer.safeDivide(sumInputBatchSizes, 
numIncomingBatches);
    +  }
    +
    +  public long getAvgInputRowWidth() {
    +    return RecordBatchSizer.safeDivide(sumInputRowWidths, 
numIncomingBatches);
    --- End diff --
    
    See below regarding the average calculation.


---