Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1198#discussion_r178364263
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillReduceAggregatesRule.java
---
@@ -218,7 +218,8 @@ private void reduceAggs(
RelOptUtil.createProject(
newAggRel,
projList,
- oldAggRel.getRowType().getFieldNames());
+ oldAggRel.getRowType().getFieldNames(),
+ DrillRelFactories.LOGICAL_BUILDER);
--- End diff --
Could you explain why we are using DrillRelFactories.LOGICAL_BUILDER but
not relBuilderFactory that was used in line 211? And could you point me to this
4 param createProject method with Factory as the last param?
---
