Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1198#discussion_r178395314
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -1142,16 +1142,8 @@ public void moveToCurrentRow() throws SQLException {
}
@Override
- public AvaticaStatement getStatement() {
- try {
- throwIfClosed();
- } catch (AlreadyClosedSqlException e) {
- // Can't throw any SQLException because AvaticaConnection's
- // getStatement() is missing "throws SQLException".
- throw new RuntimeException(e.getMessage(), e);
- } catch (SQLException e) {
- throw new RuntimeException(e.getMessage(), e);
- }
+ public AvaticaStatement getStatement() throws SQLException {
+ throwIfClosed();
--- End diff --
Since you are touching this file. You might want to remove not needed
Exceptions for throwIfClosed() method that are derives of SqlException.
---