Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1203#discussion_r181830465
  
    --- Diff: 
common/src/main/java/org/apache/drill/exec/metrics/CpuGaugeSet.java ---
    @@ -0,0 +1,62 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.metrics;
    +
    +import java.lang.management.OperatingSystemMXBean;
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +import com.codahale.metrics.Gauge;
    +import com.codahale.metrics.Metric;
    +import com.codahale.metrics.MetricSet;
    +
    +/**
    + * Creates a Cpu GaugeSet
    + */
    +class CpuGaugeSet implements MetricSet {
    --- End diff --
    
    I am not sure how useful `getProcessCpuLoad` alone will be, but in addition 
with total system load it can give the idea about how Drill and other services 
on node are using the CPU.  If you plan to include another metric then in that 
case `CpuGaugeSet` class is fine. Thanks for clarification.


---

Reply via email to