Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1203#discussion_r182500652
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -67,9 +73,15 @@
<td>${i}</td>
<td id="address" >${drillbit.getAddress()}<#if
drillbit.isCurrent()>
<span class="label label-info"
id="current">Current</span>
+ <#else>
+ <a
onclick="popOutRemoteDbitUI('${drillbit.getAddress()}','${drillbit.getHttpPort()}');"
style="cursor:pointer;color:blue" title="Open in new window"><span
class="glyphicon glyphicon-new-window"/></a>
--- End diff --
The `shutdown()` method should be in the freemarker's IF block that checks
for authentication. Any other method is benign and does not risk changing the
state of the Drillbit.
Also, this method simply will pop out a new window from which that
Drillbit's UI can be accessed. This should help if someone wishes to navigate
to that node to, say, review logs or even submit queries with that node as the
foreman, without having to type the address (which might have a different HTTP
port).
---
