Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/1241#discussion_r185115283
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -103,14 +105,14 @@
</td>
<td id="status" >${drillbit.getState()}</td>
<td class="uptime" >Not Available</td>
- <td>
- <#if ( model.shouldShowAdminInfo() && (
drillbit.isCurrent() || ( !model.isAuthEnabled() && location.protocol !=
"https" ))) >
- <button type="button" id="shutdown"
onClick="shutdown($(this),
'${drillbit.getAddress()}:${drillbit.getHttpPort()}');">
- <#else>
+ <td>
+ <#if ( model.shouldShowAdminInfo() ||
!model.isAuthEnabled() || drillbit.isCurrent() ) >
--- End diff --
This check doesn't look correct to me. `shouldShowAdminInfo` checks If the
logged in user is admin or not. So for admin user it will show the shutdown
button in if block even for remote Drillbit which is not the intention.
---
