Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1241#discussion_r185113634
  
    --- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
    @@ -328,9 +432,11 @@
           //Iterates through all the nodes for update
           function reloadMetrics() {
               for (i = 1; i <= size; i++) {
    -              var address = 
$("#row-"+i).find("#address").contents().get(0).nodeValue.trim();
    -              var httpPort = 
$("#row-"+i).find("#httpPort").contents().get(0).nodeValue.trim();
    -              updateMetricsHtml(address, httpPort, i);
    +              if ( $("#row-"+i).find("#stateKey").length == 0 ) {
    +                var address = 
$("#row-"+i).find("#address").contents().get(0).nodeValue.trim();
    +                var httpPort = 
$("#row-"+i).find("#httpPort").contents().get(0).nodeValue.trim();
    +                updateMetricsHtml(address, httpPort, i);
    --- End diff --
    
    Please update the check inside `updateMetricsHtml`, it will not refresh for 
local bit in case when Auth is enabled.
    ```
    Current:
    if ( !updateRemoteInfo || (location.protocol == "https" && remoteHost != 
location.host) ) {
               return;
    }
    
    Should Be:
    if ( (!updateRemoteInfo || (location.protocol == "https") && remoteHost != 
location.host ) {
               return;
    }
    ```


---

Reply via email to