arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill
Plugins Handler
URL: https://github.com/apache/drill/pull/1345#discussion_r198845924
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java
##########
@@ -121,71 +117,96 @@ public StoragePlugin load(StoragePluginConfig config)
throws Exception {
}
@Override
- public void init() throws DrillbitStartupException {
+ public void init() {
availablePlugins = findAvailablePlugins(classpathScan);
- // create registered plugins defined in "storage-plugins.json"
- plugins.putAll(createPlugins());
- }
-
- @SuppressWarnings("resource")
- private Map<String, StoragePlugin> createPlugins() throws
DrillbitStartupException {
try {
- /*
- * Check if the storage plugins system table has any entries. If not,
load the boostrap-storage-plugin file into
- * the system table.
- */
+ StoragePlugins pluginsToBeWrittenToPersistenceStore = null;
+ final boolean isPluginsUpdaterEnabled =
context.getConfig().getBoolean(ExecConstants.STORAGE_PLUGINS_UPDATE);
Review comment:
No, need for final.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
