arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill
Plugins Handler
URL: https://github.com/apache/drill/pull/1345#discussion_r198842531
##########
File path: common/src/main/java/org/apache/drill/exec/metrics/DrillMetrics.java
##########
@@ -36,11 +36,11 @@
private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(DrillMetrics.class);
public static final boolean METRICS_JMX_OUTPUT_ENABLED =
- SystemPropertyUtil.getBoolean("drill.metrics.jmx.enabled", true);
+ SystemPropertyUtil.getBoolean("drill.exec.metrics.jmx.enabled", true);
Review comment:
What is the reason of changing metrics names? I don't think this is safe as
users might be already using them and you'll break their functionality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
