Agirish commented on a change in pull request #1350: DRILL-4580: Support for 
exporting storage plugin configurations
URL: https://github.com/apache/drill/pull/1350#discussion_r199034500
 
 

 ##########
 File path: exec/java-exec/src/main/resources/rest/storage/update.ftl
 ##########
 @@ -48,6 +48,7 @@
       <#else>
         <a id="enabled" class="btn btn-primary">Enable</a>
       </#if>
+      <a class="btn btn-default" 
href="/storage/${model.getName()}/export"">Export</a>
 
 Review comment:
   Thanks Chunhui! I am not sure what's needed to qualify these APIs as stable. 
Can you please clarify? I don't foresee anything which could break them in 
future releases, as it's pretty generic. 
   
   Also, I couldn't find any sample unit tests for these REST APIs - so I'm not 
sure how to proceed with it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to