Agirish commented on a change in pull request #1350: DRILL-4580: Support for
exporting storage plugin configurations
URL: https://github.com/apache/drill/pull/1350#discussion_r199026541
##########
File path: exec/java-exec/src/main/resources/rest/storage/list.ftl
##########
@@ -38,6 +38,7 @@
<td style="border:none;">
<a class="btn btn-primary"
href="/storage/${plugin.getName()}">Update</a>
<a class="btn btn-default"
onclick="doEnable('${plugin.getName()}', false)">Disable</a>
+ <a class="btn btn-default"
href="/storage/${plugin.getName()}/export"">Export</a>
Review comment:
I've added it for all plugins. For Enabled it is visible in the Storage
Plugin List Page. For Enabled + Disabled, it's also visible in the Update page.
We can make it visible for Disabled plugins in the main page - but kept it
this way to reduce UI clutter. We can also remove the Export button for enabled
plugins in the main page (and only keep the button in the Update page). Can you
look at the screenshots and see what's preferable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
