sachouche commented on a change in pull request #1330: DRILL-6147: Adding
Columnar Parquet Batch Sizing functionality
URL: https://github.com/apache/drill/pull/1330#discussion_r198932595
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java
##########
@@ -680,4 +687,13 @@ public static String bootDefaultFor(String name) {
public static final String ALLOW_LOOPBACK_ADDRESS_BINDING =
"drill.exec.allow_loopback_address_binding";
+ /** Enables batch size statistics logging */
+ public static final String STATS_LOGGING_BATCH_SIZE_OPTION =
"drill.exec.stats.logging.batch_size";
+ public static final BooleanValidator STATS_LOGGING_BATCH_SIZE_VALIDATOR =
new BooleanValidator(STATS_LOGGING_BATCH_SIZE_OPTION);
+
+ /** Enables fine-grained batch size statistics logging */
+ public static final String STATS_LOGGING_FG_BATCH_SIZE_OPTION =
"drill.exec.stats.logging.fine_grained.batch_size";
+ public static final BooleanValidator STATS_LOGGING_BATCH_FG_SIZE_VALIDATOR =
new BooleanValidator(STATS_LOGGING_FG_BATCH_SIZE_OPTION);
Review comment:
@ilooner and I had an offline chat where I explained what this commit was
trying to achieve:
- Centralize batch statistics logging behavior
- All batch statistics should be logged when debug level set
- User should be able to control batch statistics behavior within a client
session: a) what operator stats to log and b) coarse vs fine grained stats
NOTE - Currently, Drill logging is static as a server restart is required to
modify the logging behavior
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
