sachouche commented on a change in pull request #1330: DRILL-6147: Adding
Columnar Parquet Batch Sizing functionality
URL: https://github.com/apache/drill/pull/1330#discussion_r199031515
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenColumnBulkInput.java
##########
@@ -160,11 +191,41 @@ public final void done() {
// Page read position is meaningful only when dictionary mode is off
if (pageInfo.dictionaryValueReader == null
- || !pageInfo.dictionaryValueReader.isDefined()) {
+ || !pageInfo.dictionaryValueReader.isDefined()) {
parentInst.pageReader.readyToReadPosInBytes = oprReadState.pageReadPos;
}
parentInst.pageReader.valuesRead = oprReadState.numPageFieldsProcessed;
- parentInst.totalValuesRead += oprReadState.batchFieldIndex;
+ parentInst.totalValuesRead += oprReadState.batchNumValuesReadFromPages;
+
+ if (logger.isDebugEnabled()) {
+ String message = String.format("requested=%d, returned=%d,
total-returned=%d",
Review comment:
I prefer the String.format(...) API because it has superior type checking
and formatting capabilities.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
