amansinha100 commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r199638120
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java
##########
@@ -375,6 +378,30 @@ protected void cleanup() {
public FragmentExecutor getFragmentRunner(final FragmentHandle handle) {
return runningFragments.get(handle);
}
+
+ public void receiveRuntimeFilter(final RuntimeFilterWritable
runtimeFilter) {
+ BitData.RuntimeFilterBDef runtimeFilterDef =
runtimeFilter.getRuntimeFilterBDef();
+ boolean toForeman = runtimeFilterDef.getToForeman();
+ QueryId queryId = runtimeFilterDef.getQueryId();
+ //to foreman
+ if (toForeman) {
+ Foreman foreman = queries.get(queryId);
+ if (foreman != null) {
Review comment:
In what cases will the foreman be null ? If toForeman is true, I assume this
message was only sent to the foreman node. The other possibility is the
foreman has crashed. Is that what this is supposed to handle ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services