amansinha100 commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r199558705
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ScanPrel.java
##########
@@ -151,12 +151,12 @@ public RelOptCost computeSelfCost(final RelOptPlanner
planner, RelMetadataQuery
@Override
public SelectionVectorMode[] getSupportedEncodings() {
- return SelectionVectorMode.DEFAULT;
+ return SelectionVectorMode.NONE_AND_TWO;
}
@Override
public SelectionVectorMode getEncoding() {
- return SelectionVectorMode.NONE;
+ return SelectionVectorMode.TWO_BYTE;
Review comment:
Can you check if NONE_AND_TWO works for this case ? If the JPPD is not
applicable, an SV2 is not created right ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
