vvysotskyi commented on a change in pull request #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization) URL: https://github.com/apache/drill/pull/1386#discussion_r203427936
########## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestLateLimit0Optimization.java ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.physical.impl.limit; + +import org.apache.drill.test.BaseTestQuery; +import org.apache.drill.PlanTestBase; +import org.junit.Test; + +public class TestLateLimit0Optimization extends BaseTestQuery { + + @Test + public void convertFromJson() throws Exception { + checkThatQueryIsNotOptimized("SELECT CONVERT_FROM('{x:100, y:215.6}' ,'JSON') AS MYCOL FROM (VALUES(1))"); + } + + private static void checkThatQueryIsNotOptimized(final String query) throws Exception { + PlanTestBase.testPlanMatchingPatterns(wrapLimit0(query), + new String[]{}, + new String[]{ + ".*Limit\\(offset=\\[0\\], fetch=\\[0\\]\\)(.*[\n\r])+.*Scan.*" + }); + } + + private static String wrapLimit0(final String query) { + return "SELECT * FROM (" + query + ") LZT LIMIT 0"; + } + + @Test + public void convertToIntBE() throws Exception { + checkThatQueryIsOptimized("SELECT CONVERT_TO(r_regionkey, 'INT_BE') FROM cp.`tpch/region.parquet`"); + } + + private static void checkThatQueryIsOptimized(final String query) throws Exception { + PlanTestBase.testPlanMatchingPatterns(wrapLimit0(query), Review comment: `PlanTestBase` has a method which takes two arguments, please use that method here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
