vvysotskyi commented on a change in pull request #1386: DRILL-6574: Add option
to push LIMIT(0) on top of SCAN (late limit 0 optimization)
URL: https://github.com/apache/drill/pull/1386#discussion_r203419904
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/FindLimit0Visitor.java
##########
@@ -126,9 +161,84 @@ public static boolean containsLimit0(final RelNode rel) {
return visitor.isContains();
}
- private boolean contains = false;
+ /**
+ * TODO(DRILL-3993): Use RelBuilder to create a limit node to allow for
applying this optimization in potentially
Review comment:
Please remove this comment. I don't think that it should be done in
`RelBuilder` since rel node should be checked starting from the top, but
`RelBuilder` may be used at any level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
