parthchandra commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest URL: https://github.com/apache/drill/pull/1401#discussion_r205896496
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestImpl.java ########## @@ -36,9 +36,12 @@ import static org.apache.drill.exec.record.BatchSchema.SelectionVectorMode.NONE; /** - * Contains the actual unnest operation. Unnest is a simple transfer operation in this impelementation. + * Contains the actual unnest operation. Unnest is a simple transfer operation in this implementation. * For use as a table function, we will need to change the logic of the unnest method to operate on * more than one row at a time and remove any dependence on Lateral + * Additionally, unnest produces an implicit rowId column that allows unnest to output batches with many + * rows of incoming data being unnested in a single call to innerNext(). Downstream blocking operators need + * to be aware of this rowId column and include the rowId a sort or group by key. Review comment: done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
