parthchandra commented on a change in pull request #1401: DRILL-6616: Batch
Processing for Lateral/Unnest
URL: https://github.com/apache/drill/pull/1401#discussion_r205903322
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/LateralJoinPOP.java
##########
@@ -46,20 +49,22 @@ public LateralJoinPOP(
@JsonProperty("left") PhysicalOperator left,
@JsonProperty("right") PhysicalOperator right,
@JsonProperty("joinType") JoinRelType joinType,
+ @JsonProperty("implicitColumn") String implicitColumn,
Review comment:
Can we call this implicitRowId?
implicitColumn can cause confusion with the implicit columns generated by
scans.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
