sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD
feature
URL: https://github.com/apache/drill/pull/1334#discussion_r204136170
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataServerRequestHandler.java
##########
@@ -44,14 +44,22 @@
private final WorkEventBus workBus;
private final WorkManager.WorkerBee bee;
+ private RuntimeFilterRequestHandler runtimeFilterRequestHandler;
+
public DataServerRequestHandler(WorkEventBus workBus, WorkManager.WorkerBee
bee) {
this.workBus = workBus;
this.bee = bee;
+ this.runtimeFilterRequestHandler = new RuntimeFilterRequestHandler(bee);
}
@Override
public void handle(DataServerConnection connection, int rpcType, ByteBuf
pBody, ByteBuf dBody,
ResponseSender sender) throws RpcException {
+ if (rpcType == BitData.RpcType.REQ_RUNTIME_FILTER_VALUE) {
Review comment:
I think we can improve this `handle` method and there is no need to have
separate handler per say for this different message. Instead we can have
something similar to
[ControlMessageHandler](https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlMessageHandler.java#L65).
That is to say have a separate method to handle different request type which
will return whether the request was successful or failure and the `handle`
method will then send `Ack.OK` or `Ack.FAIL` accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
