sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD
feature
URL: https://github.com/apache/drill/pull/1334#discussion_r205907403
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
##########
@@ -528,6 +590,27 @@ private void initializeBuild() {
}
+ private void initializeRuntimeFilter() {
+ if (!enableRuntimeFilter) {
+ return;
+ }
+ if (runtimeFilterReporter != null) {
+ return;
+ }
+ runtimeFilterReporter = new
RuntimeFilterReporter((ExecutorFragmentContext) context);
+ RuntimeFilterDef runtimeFilterDef = popConfig.getRuntimeFilterDef();
+ if (runtimeFilterDef != null) {
Review comment:
instead of the if check shouldn't there be
`Preconditions.checkState(runtimeFilterDef != null)` ? Since if
`enableRuntimeFilter` is true it's always expected to have this
`runtimeFilterDef` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
