sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r207744948
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java ########## @@ -528,6 +590,27 @@ private void initializeBuild() { } + private void initializeRuntimeFilter() { + if (!enableRuntimeFilter) { + return; + } + if (runtimeFilterReporter != null) { + return; + } + runtimeFilterReporter = new RuntimeFilterReporter((ExecutorFragmentContext) context); + RuntimeFilterDef runtimeFilterDef = popConfig.getRuntimeFilterDef(); + if (runtimeFilterDef != null) { Review comment: Thanks for explanation. It would be great to add a comment just before null check. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services