ilooner commented on a change in pull request #1344: DRILL-6461: Added basic
data correctness tests for hash agg, and improved operator unit testing
framework.
URL: https://github.com/apache/drill/pull/1344#discussion_r208711677
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java
##########
@@ -42,6 +42,8 @@
private final BufferAllocator allocator;
protected final List<VectorWrapper<?>> wrappers = Lists.newArrayList();
private BatchSchema schema;
+ private SelectionVector2 selectionVector2;
+ private SelectionVector4 selectionVector4;
Review comment:
This has actually been a point of confusion for me. VectorContainer and
RecordBatch both implement VectorAccessible, which has the following methods:
```
SelectionVector2 getSelectionVector2();
SelectionVector4 getSelectionVector4();
```
If the intention is that VectorContainers should never hold selection
vectors, then the interfaces VectorContainer implements should reflect that.
What are you're thoughts about refactoring the VectorAccessable to remove the
selection vector methods? In the meantime I will remove these changes from
VectorContainer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
