ilooner commented on a change in pull request #1344: DRILL-6461: Added basic
data correctness tests for hash agg, and improved operator unit testing
framework.
URL: https://github.com/apache/drill/pull/1344#discussion_r208770691
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java
##########
@@ -639,6 +641,8 @@ public ColumnSize getColumn(String name) {
// columns can be obtained from children of topColumns.
private Map<String, ColumnSize> columnSizes =
CaseInsensitiveMap.newHashMap();
+ private List<ColumnSize> columnSizesList = new ArrayList<>();
Review comment:
It's for convenience. VectorContainers expose their ValueVectors based on
index, so it is handy to be able to lookup column size based on the same index
as well. Otherwise I would have to get the Materialized field for the a column,
extract the name, and then lookup the ColumnSize in the map.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
