amansinha100 commented on a change in pull request #1466: DRILL-6381: Add
support for index based planning and execution
URL: https://github.com/apache/drill/pull/1466#discussion_r224928601
##########
File path:
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/json/MaprDBJsonRecordReader.java
##########
@@ -517,6 +388,15 @@ private static FieldPath
getFieldPathForProjection(SchemaPath column) {
return new FieldPath(child);
}
+ public static boolean includesIdField(Collection<FieldPath> projected) {
+ return Iterables.tryFind(projected, new Predicate<FieldPath>() {
Review comment:
Since this is a syntactic modification, I am inclined to leave it as-is ..
partly because I might cause an unintentional side effect/regression and partly
because such functional utilities appear elsewhere in the Drill and Calcite
code. Ideally, if we want to move to Lambdas, we should re-visit all such
implementations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
