amansinha100 commented on a change in pull request #1466: DRILL-6381: Add 
support for index based planning and execution
URL: https://github.com/apache/drill/pull/1466#discussion_r225740876
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillMergeProjectRule.java
 ##########
 @@ -166,4 +169,25 @@ public void onMatch(RelOptRuleCall call) {
     return list;
   }
 
+  public static Project replace(Project topProject, Project bottomProject) {
 
 Review comment:
   They can be merged into the top level Project that allows 
duplicates...however, the purpose of the `replace()` method here is to simply 
allow the caller to replace a project with another with the assumption that 
callers know exactly what they are doing.  This is not applying the full 
fledged `DrillMergeProjectRule`. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to