weijietong commented on a change in pull request #1504: DRILL-6792: Find the
right probe side fragment wrapper & fix DrillBuf…
URL: https://github.com/apache/drill/pull/1504#discussion_r230543377
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContextImpl.java
##########
@@ -362,12 +368,35 @@ public boolean isUserAuthenticationEnabled() {
@Override
public void addRuntimeFilter(RuntimeFilterWritable runtimeFilter) {
- this.runtimeFilterSink.aggregate(runtimeFilter);
+ this.runtimeFilterWritable = runtimeFilter;
+ if (enableRFWaiting) {
+ condition.signal();
+ }
Review comment:
Here there's a usage bug about the signal ,I have fixed that on the latest
commit. But I don't want to add unnecessary lock to the runtimeFilterWritable
var. Drill's code has lots of sync usage. I always try to thin the block size,
though it maybe introduce bugs. If you insist on this, I am open to do it at
another commit. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
