weijietong commented on a change in pull request #1504: DRILL-6792: Find the
right probe side fragment wrapper & fix DrillBuf…
URL: https://github.com/apache/drill/pull/1504#discussion_r236042950
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContextImpl.java
##########
@@ -136,8 +143,8 @@ public void interrupt(final InterruptedException e) {
private final AccountingUserConnection accountingUserConnection;
/** Stores constants and their holders by type */
private final Map<String, Map<MinorType, ValueHolder>>
constantValueHolderCache;
-
- private RuntimeFilterSink runtimeFilterSink;
+ private Map<Long, RuntimeFilterWritable> rfIdentifier2RFW = new
ConcurrentHashMap<>();
+ private Map<Long, Boolean> rfIdentifier2fetched = new ConcurrentHashMap<>();
Review comment:
Still keep the original implementation. The reason is we fetch the RFW more
than one times at the `RuntimeFilterRecordBatch` side. If we remove it from the
`rfIdentifier2RFW` map, it will cause NPE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
