vdiravka commented on a change in pull request #1528: DRILL-3610: Add
TIMESTAMPADD and TIMESTAMPDIFF functions
URL: https://github.com/apache/drill/pull/1528#discussion_r232229127
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillConvertletTable.java
##########
@@ -61,13 +69,36 @@
}
};
+ // Custom convertlet to avoid rewriting TIMESTAMP_DIFF by Calcite.
Review comment:
please add the small note about the reason why Calcite's
`TimestampDiffConvertlet` is not suitable for Drill (similar to desc in PR).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
