vdiravka commented on a change in pull request #1528: DRILL-3610: Add 
TIMESTAMPADD and TIMESTAMPDIFF functions
URL: https://github.com/apache/drill/pull/1528#discussion_r232034213
 
 

 ##########
 File path: 
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestDateAddFunctions.java
 ##########
 @@ -30,6 +35,29 @@
 @Category({UnlikelyTest.class, SqlFunctionTest.class})
 public class TestDateAddFunctions extends BaseTestQuery {
 
 Review comment:
   Looks like `TIMESTAMPDIFF` and `TIMESTAMPADD` differ from `DATE_ADD`, 
therefore please create a separate class for the new unit tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to