arina-ielchiieva commented on a change in pull request #1539: DRILL-6847: Add Query Metadata to RESTful Interface URL: https://github.com/apache/drill/pull/1539#discussion_r233423505
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebUserConnection.java ########## @@ -106,7 +110,10 @@ public void sendData(RpcOutcomeListener<Ack> listener, QueryWritableBatch result // TODO: Clean: DRILL-2933: That load(...) no longer throws // SchemaChangeException, so check/clean catch clause below. for (int i = 0; i < loader.getSchema().getFieldCount(); ++i) { - columns.add(loader.getSchema().getColumn(i).getName()); + + MaterializedField col = loader.getSchema().getColumn(i); + columns.add(col.getName()); + metadata.add(col.getType().getMinorType().name()); Review comment: I see but though it is not your use case, I think we should consider shipping not only String type but as well information about precision and scale for those who might need it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services