arina-ielchiieva commented on a change in pull request #1539: DRILL-6847: Add
Query Metadata to RESTful Interface
URL: https://github.com/apache/drill/pull/1539#discussion_r235101788
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebUserConnection.java
##########
@@ -106,7 +110,30 @@ public void sendData(RpcOutcomeListener<Ack> listener,
QueryWritableBatch result
// TODO: Clean: DRILL-2933: That load(...) no longer throws
// SchemaChangeException, so check/clean catch clause below.
for (int i = 0; i < loader.getSchema().getFieldCount(); ++i) {
- columns.add(loader.getSchema().getColumn(i).getName());
+ //DRILL-6847: This section adds query metadata to the REST results
+ MaterializedField col = loader.getSchema().getColumn(i);
+ columns.add(col.getName());
+ StringBuilder dataType = new
StringBuilder(col.getType().getMinorType().name());
+
+ //For DECIMAL type
+ if (col.getType().hasPrecision()) {
+ dataType.append("(");
+ dataType.append(col.getType().getPrecision());
+
+ if (col.getType().hasScale()) {
+ dataType.append((", "));
Review comment:
Please remove extra parenthesis and squash the commits. Also make sure
commit message is in proper style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
