paul-rogers commented on a change in pull request #1599: DRILL-6903:
SchemaBuilder code improvements
URL: https://github.com/apache/drill/pull/1599#discussion_r245888897
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/test/TestSchemaBuilder.java
##########
@@ -81,7 +79,7 @@ public void testRowPreBuilt() {
MaterializedField aField = MaterializedField.create("a",
Types.optional(MinorType.VARCHAR));
- AbstractColumnMetadata bCol = MetadataUtils.newScalar("b",
+ ColumnMetadata bCol = MetadataUtils.newScalar("b",
Review comment:
Consider adding test functions for the new stand-alone versions of the
builders.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
