paul-rogers commented on a change in pull request #1599: DRILL-6903:
SchemaBuilder code improvements
URL: https://github.com/apache/drill/pull/1599#discussion_r245888149
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/record/metadata/TupleBuilder.java
##########
@@ -139,21 +135,17 @@ public MapBuilder addMapArray(SchemaContainer parent,
String name) {
}
public UnionBuilder addUnion(SchemaContainer parent, String name) {
- return new UnionBuilder(parent, name, MinorType.UNION, DataMode.OPTIONAL);
+ return new UnionBuilder(parent, name, MinorType.UNION);
}
public UnionBuilder addList(SchemaContainer parent, String name) {
- return new UnionBuilder(parent, name, MinorType.LIST, DataMode.REPEATED);
+ return new UnionBuilder(parent, name, MinorType.LIST);
Review comment:
Nice simplification, since the type implies the mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
