cgivre commented on a change in pull request #1530: DRILL-6582: SYSLOG
(RFC-5424) Format Plugin
URL: https://github.com/apache/drill/pull/1530#discussion_r254140727
##########
File path:
protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java
##########
@@ -895,6 +903,7 @@ public static CoreOperatorType valueOf(int value) {
case 55: return PCAPNG_SUB_SCAN;
case 56: return RUNTIME_FILTER;
case 57: return ROWKEY_JOIN;
+ case 58: return SYSLOG_SUB_SCAN;
Review comment:
@vdiravka
I added the protobuf and rebuilt using maven without problem. However, I
couldn't get the c++ code to build. I'm not really sure what to do about this.
```
cd build && cmake -G "Unix Makefiles" ..
-- The C compiler identification is AppleClang 10.0.0.10001145
-- The CXX compiler identification is AppleClang 10.0.0.10001145
-- Check for working C compiler:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
-- Check for working C compiler:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
-- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
-- Check for working CXX compiler:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
-- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
Detecting Drill version:
Project Dir = /Users/cgivre/github/drill-dev/drill/contrib/native/client
Project Version = 1.16.0
Source Dir = /Users/cgivre/github/drill-dev/drill/contrib/native/client
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - found
-- Found Threads: TRUE
-- Boost version: 1.68.0
-- Found the following Boost libraries:
-- regex
-- system
-- date_time
-- chrono
-- thread
-- random
-- atomic
CMake Error at
/usr/local/Cellar/cmake/3.13.3/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:137
(message):
Could NOT find Protobuf (missing: Protobuf_LIBRARIES Protobuf_INCLUDE_DIR)
Call Stack (most recent call first):
/usr/local/Cellar/cmake/3.13.3/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:378
(_FPHSA_FAILURE_MESSAGE)
/usr/local/Cellar/cmake/3.13.3/share/cmake/Modules/FindProtobuf.cmake:595
(FIND_PACKAGE_HANDLE_STANDARD_ARGS)
CMakeLists.txt:127 (find_package)
-- Configuring incomplete, errors occurred!
See also
"/Users/cgivre/github/drill-dev/drill/contrib/native/client/build/CMakeFiles/CMakeOutput.log".
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
