cgivre commented on a change in pull request #1530: DRILL-6582: SYSLOG (RFC-5424) Format Plugin URL: https://github.com/apache/drill/pull/1530#discussion_r256207563
########## File path: contrib/native/client/src/protobuf/UserBitShared.pb.h ########## @@ -1,65 +1,152 @@ // Generated by the protocol buffer compiler. DO NOT EDIT! // source: UserBitShared.proto -#ifndef PROTOBUF_UserBitShared_2eproto__INCLUDED -#define PROTOBUF_UserBitShared_2eproto__INCLUDED +#ifndef PROTOBUF_INCLUDED_UserBitShared_2eproto +#define PROTOBUF_INCLUDED_UserBitShared_2eproto #include <string> #include <google/protobuf/stubs/common.h> -#if GOOGLE_PROTOBUF_VERSION < 2005000 +#if GOOGLE_PROTOBUF_VERSION < 3006001 Review comment: @vdiravka I updated with the correct version (I think) of the protobufs. Just as an FYSA (and in case I have to do this again), I was having a lot of trouble because I have Anaconda installed on my Mac which seems to install its own version of clang which doesn't work with these libraries. Running with `sudo` permissions seemed to fix it. ``` sudo cmake -G "Unix Makefiles" -DOPENSSL_ROOT_DIR="/usr/local/opt/openssl" -DOPENSSL_INCLUDE_DIR="/usr/local/opt/openssl/include" -DOPENSSL_LIBRARIES="/usr/local/opt/openssl/lib " .. ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
