KazydubB commented on a change in pull request #1635: DRILL-7021: HTTPD Throws
NPE and Doesn't Recognize Timeformat
URL: https://github.com/apache/drill/pull/1635#discussion_r262822464
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/httpd/HttpdLogFormatPlugin.java
##########
@@ -155,8 +105,12 @@ public HttpdLogRecordReader(final FragmentContext
context, final DrillFileSystem
final Map<String, String> fieldMapping = Maps.newHashMap();
for (final SchemaPath sp : getColumns()) {
final String drillField = sp.getRootSegment().getPath();
- final String parserField =
HttpdParser.parserFormattedFieldName(drillField);
- fieldMapping.put(drillField, parserField);
+ try {
+ final String parserField =
HttpdParser.parserFormattedFieldName(drillField);
+ fieldMapping.put(drillField, parserField);
+ } catch (Exception e) {
+ LOG.info("Putting field: " + drillField + " into map", e);
Review comment:
Is it OK to proceed if one `drillField` was not mapped?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
