KazydubB commented on a change in pull request #1635: DRILL-7021: HTTPD Throws
NPE and Doesn't Recognize Timeformat
URL: https://github.com/apache/drill/pull/1635#discussion_r264606778
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/httpd/HttpdLogFormatPlugin.java
##########
@@ -169,11 +119,15 @@ public HttpdLogRecordReader(final FragmentContext
context, final DrillFileSystem
* @return Map with Drill field names as a key and Parser Field names as a
value
*/
private Map<String, String> makeParserFields() {
- final Map<String, String> fieldMapping = Maps.newHashMap();
+ Map<String, String> fieldMapping = Maps.newHashMap();
Review comment:
According to [Maps
docs](https://google.github.io/guava/releases/23.0/api/docs/com/google/common/collect/Maps.html#newHashMap--)
`newHashMap()` ` [...] method is now unnecessary and should be treated as
deprecated. Instead, use the HashMap constructor directly, taking advantage of
the new "diamond" syntax.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
