KazydubB commented on a change in pull request #1635: DRILL-7021: HTTPD Throws
NPE and Doesn't Recognize Timeformat
URL: https://github.com/apache/drill/pull/1635#discussion_r265019480
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/httpd/HttpdParser.java
##########
@@ -134,23 +383,88 @@
LOGFIELDS.put("request_receive_time_end_usec_frac",
"TIME_EPOCH_USEC_FRAC:request_receive_time_end_usec_frac");
LOGFIELDS.put("response_server_processing_time",
"SECONDS:response_server_processing_time");
LOGFIELDS.put("connection_client_user",
"STRING:connection_client_user");
+ LOGFIELDS.put("connection_client_user_last",
"STRING:connection_client_user");
LOGFIELDS.put("request_urlpath", "URI:request_urlpath");
LOGFIELDS.put("connection_server_name_canonical",
"STRING:connection_server_name_canonical");
LOGFIELDS.put("connection_server_name",
"STRING:connection_server_name");
LOGFIELDS.put("response_connection_status",
"HTTP_CONNECTSTATUS:response_connection_status");
LOGFIELDS.put("request_bytes", "BYTES:request_bytes");
LOGFIELDS.put("response_bytes", "BYTES:response_bytes");
- }
+ LOGFIELDS.put("request_firstline_uri_query_$",
"STRING:request_firstline_uri_query_$");
+ LOGFIELDS.put("request_receive_time_last_nanosecond__utc",
"TIME_NANOSECOND:request_receive_time_last_nanosecond__utc");
+ LOGFIELDS.put("request_receive_time_last_time",
"TIME_STAMP:request_receive_time_last_time");
+
LOGFIELDS.put("request_firstline_original_uri_query_$","STRING:request_firstline_original_uri_query_$");
+ LOGFIELDS.put("request_receive_time_microsecond",
"TIME_MICROSECOND:request_receive_time_microsecond");
+ LOGFIELDS.put("request_receive_time_last_microsecond__utc",
"TIME_MICROSECOND:request_receive_time_last_microsecond__utc");
+ LOGFIELDS.put("request_firstline_original_protocol",
"STRING:request_firstline_original_protocol");
+ LOGFIELDS.put("request_firstline_original_uri_host",
"HTTP_HOST:request_firstline_original_uri_host");
+ LOGFIELDS.put("request_receive_time_last_minute",
"TIME_MINUTE:request_receive_time_last_minute");
+ LOGFIELDS.put("request_receive_time_time__utc",
"TIME_STAMP:request_receive_time_time__utc");
+ LOGFIELDS.put("request_referer_last_ref",
"HTTP_REF:request_referer_last_ref");
+ LOGFIELDS.put("request_receive_time_last_timezone",
"TIME_ZONE:request_receive_time_last_timezone");
+ LOGFIELDS.put("request_receive_time_last_weekofweekyear",
"TIME_WEEK:request_receive_time_last_weekofweekyear");
+ LOGFIELDS.put("request_referer_last", "STRING:request_referer_last");
+ LOGFIELDS.put("connection_client_host_last",
"IP:connection_client_host_last");
+ LOGFIELDS.put("request_receive_time_last_millisecond__utc",
"TIME_MILLISECOND:request_receive_time_last_millisecond__utc");
+ LOGFIELDS.put("request_firstline_original_uri",
"URI:request_firstline_original_uri");
+ LOGFIELDS.put("request_receive_time_nanosecond",
"TIME_NANOSECOND:request_receive_time_nanosecond");
+ LOGFIELDS.put("request_receive_time_last_millisecond",
"TIME_MILLISECOND:request_receive_time_last_millisecond");
+ LOGFIELDS.put("request_firstline_original_uri_port",
"HTTP_PORT:request_firstline_original_uri_port");
+ LOGFIELDS.put("request_receive_time_last_date",
"TIME_DATE:request_receive_time_last_date");
+ LOGFIELDS.put("request_receive_time_last_time__utc",
"TIME_STAMP:request_receive_time_last_time__utc");
+ LOGFIELDS.put("request_receive_time_last_hour__utc",
"TIME_HOUR:request_receive_time_last_hour__utc");
+ LOGFIELDS.put("request_firstline_original_protocol_version",
"NUMBER:request_firstline_original_protocol_version");
+ LOGFIELDS.put("request_firstline_original_method",
"STRING:request_firstline_original_method");
+ LOGFIELDS.put("request_receive_time_last_year__utc",
"TIME_YEAR:request_receive_time_last_year__utc");
+ LOGFIELDS.put("request_referer_last_host",
"HTTP_HOST:request_referer_last_host");
+ LOGFIELDS.put("request_receive_time_last_minute__utc",
"TIME_MINUTE:request_receive_time_last_minute__utc");
+ LOGFIELDS.put("request_receive_time_nanosecond__utc",
"TIME_NANOSECOND:request_receive_time_nanosecond__utc");
+ LOGFIELDS.put("request_receive_time_microsecond__utc",
"TIME_MICROSECOND:request_receive_time_microsecond__utc");
+ LOGFIELDS.put("request_referer_last_port",
"PORT:request_referer_last_port");
+ LOGFIELDS.put("request_receive_time_last_epoch",
"TIME_EPOCH:request_receive_time_last_epoch");
+ LOGFIELDS.put("request_receive_time_last_weekyear__utc",
"TIME_YEAR:request_receive_time_last_weekyear__utc");
+ LOGFIELDS.put("request_receive_time_last_date__utc",
"TIME_DATE:request_receive_time_last_date__utc");
+ LOGFIELDS.put("request_referer_last_protocol",
"PROTOCOL:request_referer_last_protocol");
+ LOGFIELDS.put("request_firstline_original_uri_protocol",
"PROTOCOL:request_firstline_original_uri_protocol");
+ LOGFIELDS.put("request_receive_time_date",
"TIME_DATE:request_receive_time_date");
+ LOGFIELDS.put("request_receive_time_last_second__utc",
"TIME_SECOND:request_receive_time_last_second__utc");
+ LOGFIELDS.put("request_referer_last_userinfo",
"STRING:request_referer_last_userinfo");
+ LOGFIELDS.put("request_receive_time_last_second",
"TIME_SECOND:request_receive_time_last_second");
+ LOGFIELDS.put("request_receive_time_last_monthname__utc",
"TIME_MONTHNAME:request_receive_time_last_monthname__utc");
+ LOGFIELDS.put("request_receive_time_last_month__utc",
"TIME_MONTH:request_receive_time_last_month__utc");
+ LOGFIELDS.put("request_firstline_original_uri_ref",
"URI:request_firstline_original_uri_ref");
+ LOGFIELDS.put("connection_client_logname_last",
"STRING:connection_client_logname_last");
+ LOGFIELDS.put("request_receive_time_last_year",
"TIME_YEAR:request_receive_time_last_year");
+ LOGFIELDS.put("request_firstline_original_uri_path",
"STRING:request_firstline_original_uri_path");
+ LOGFIELDS.put("request_referer_last_query_$",
"STRING:request_referer_last_query_$");
+ LOGFIELDS.put("request_firstline_original_uri_query",
"STRING:request_firstline_original_uri_query");
+ LOGFIELDS.put("request_receive_time_last_monthname",
"TIME_MONTHNAME:request_receive_time_last_monthname");
+ LOGFIELDS.put("request_receive_time_last_month",
"TIME_MONTH:request_receive_time_last_month");
+ LOGFIELDS.put("request_referer_last_query",
"STRING:equest_referer_last_query");
+ LOGFIELDS.put("request_receive_time_last_day",
"TIME_DAY:request_receive_time_last_day");
+ LOGFIELDS.put("request_receive_time_time",
"TIME_request_receive_time_time");
+ LOGFIELDS.put("request_receive_time_last_weekofweekyear__utc",
"TIME_WEEK:request_receive_time_last_weekofweekyear__utc");
+ LOGFIELDS.put("request_user-agent_last",
"HTTP_USERAGENT:request_user-agent_last");
+ LOGFIELDS.put("request_receive_time_last_weekyear",
"TIME_YEAR:request_receive_time_last_weekyear");
+ LOGFIELDS.put("request_receive_time_last_microsecond",
"TIME_MICROSECOND:request_receive_time_last_microsecond");
+ LOGFIELDS.put("request_firstline_original",
"STRING:request_firstline_original");
+ LOGFIELDS.put("request_referer_last_path",
"STRING:request_referer_last_path");
+ LOGFIELDS.put("request_receive_time_last_day__utc",
"TIME_DAY:request_receive_time_last_day__utc");
+ LOGFIELDS.put("response_body_bytes_last",
"BYTES:response_body_bytes_last");
+ LOGFIELDS.put("request_receive_time_last_nanosecond",
"TIME_NANOSECOND:request_receive_time_last_nanosecond");
+ LOGFIELDS.put("request_firstline_original_uri_userinfo",
"STRING:request_firstline_original_uri_userinfo");
+ LOGFIELDS.put("request_receive_time_date__utc",
"DATE:request_receive_time_date__utc");*/
+ }
- //Map map = Collections.synchronizedMap(LOGFIELDS);
+ //Map map = Collections.synchronizedMap(LOGFIELDS);
Review comment:
Also remove the field, please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
