paul-rogers commented on a change in pull request #1696: DRILL-7095: Expose
table schema (TupleMetadata) to physical operator (EasySubScan)
URL: https://github.com/apache/drill/pull/1696#discussion_r266213017
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyGroupScan.java
##########
@@ -78,30 +80,41 @@ public EasyGroupScan(
@JsonProperty("format") FormatPluginConfig formatConfig,
@JacksonInject StoragePluginRegistry engineRegistry,
@JsonProperty("columns") List<SchemaPath> columns,
- @JsonProperty("selectionRoot") Path selectionRoot
+ @JsonProperty("selectionRoot") Path selectionRoot,
+ @JsonProperty("schema") TupleSchema schema
) throws IOException, ExecutionSetupException {
this(ImpersonationUtil.resolveUserName(userName),
FileSelection.create(null, files, selectionRoot),
(EasyFormatPlugin<?>)engineRegistry.getFormatPlugin(storageConfig,
formatConfig),
columns,
- selectionRoot);
+ selectionRoot,
+ schema);
}
public EasyGroupScan(String userName, FileSelection selection,
EasyFormatPlugin<?> formatPlugin, Path selectionRoot)
throws IOException {
- this(userName, selection, formatPlugin, ALL_COLUMNS, selectionRoot);
+ this(userName, selection, formatPlugin, ALL_COLUMNS, selectionRoot, null);
+ }
+
+ public EasyGroupScan(String userName, FileSelection selection,
EasyFormatPlugin<?> formatPlugin,
+ List<SchemaPath> columns, Path selectionRoot) throws
IOException {
Review comment:
Not needed now, but the arg list is getting long enough that I suspect we'll
want a "builder" abstraction at some point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
