paul-rogers commented on a change in pull request #1696: DRILL-7095: Expose
table schema (TupleMetadata) to physical operator (EasySubScan)
URL: https://github.com/apache/drill/pull/1696#discussion_r266213355
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java
##########
@@ -343,4 +344,14 @@ protected ScanStats getScanStats(final PlannerSettings
settings, final EasyGroup
final double estRowCount = data / estimatedRowSize;
return new ScanStats(GroupScanProperty.NO_EXACT_ROW_COUNT, (long)
estRowCount, 1, data);
}
+
+ @Override
+ public void setSchema(TupleMetadata schema) {
+ this.schema = schema;
+ }
Review comment:
Would be best if the schema can be immutable: set in the constructor and not
changeable once set. Else, it is very unclear what the semantics will be.
Same is true, by the way, for the scan nodes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
