vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement
JDBC Statement.setMaxRows() with System Option
URL: https://github.com/apache/drill/pull/1714#discussion_r268659959
##########
File path:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java
##########
@@ -270,4 +271,10 @@ public void setResultSet(AvaticaResultSet resultSet) {
public void setUpdateCount(int value) {
updateCount = value;
}
+
+ @Override
+ public void setLargeMaxRows(long maxRowCount) throws SQLException {
+ execute("ALTER SESSION SET `" + ExecConstants.QUERY_MAX_ROWS +
"`="+maxRowCount);
+ this.maxRowCount = maxRowCount;
Review comment:
Looks like `maxRowCount` is taken from avatica. Does it provide similar
functionality we want to implement?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
