vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r268655998
########## File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillPreparedStatement.java ########## @@ -32,4 +33,25 @@ */ public interface DrillPreparedStatement extends PreparedStatement { + /** + * @throws SQLException + * Any SQL exception + */ + @Override + int getMaxRows() throws SQLException; Review comment: What was the reason for declaring this method and the method below?They both are already available in `Statement` interface. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services